Re: [Xen-devel] [PATCH v2 13/15] xen/arm: Add support for GIC v3

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-04-04 at 17:26 +0530, vijay.kilari@xxxxxxxxx wrote:

> +#define GICD_CTLR       (0x000)
> +#define GICD_TYPER      (0x004)
> +#define GICD_IIDR       (0x008)
> +#define GICD_STATUSR    (0x010)

A lot of these are identical to the GIV v2 definitions. Is a separate
set of #defines *really* necessary?

I'd be happy with:
        #define GICD_CTLR       (0x000)
        #define GICD_TYPER      (0x004)
        #define GICD_IIDR       (0x008)
        #define GICD_STATUSR    (0x010) /* GICv3 only */
        #define GICD_BLARGLE    (0x...) /* GICv2 only */
        etc.

Or if you really feel that separate defines are needed then at the least
they should incorporate v2 and v3 into their names.
 
Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel