Re: [Xen-devel] [PATCH v2 06/15] xen/arm: move gic lock out of gic data structure

[Vijay Kilari <vijay.kilari@xxxxxxxxx>]

On Thu, Apr 10, 2014 at 3:32 PM, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> On Thu, 2014-04-10 at 14:54 +0530, Vijay Kilari wrote:
>> On Thu, Apr 10, 2014 at 2:22 PM, Ian Campbell <Ian.Campbell@xxxxxxxxxx> 
>> wrote:
>> > On Fri, 2014-04-04 at 17:26 +0530, vijay.kilari@xxxxxxxxx wrote:
>> >> From: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxxxxxxxxxx>
>> >>
>> >> spinlock is used across generic and GIC low level
>> >> functions. Move this lock out of gic data.
>> >> This helps to separate generic and low level functions
>> >> later.
>> >
>> > Is there a subsequent patch which exposes this lock to  gic-{v2,v3}.c? I
>> > grepped but couldn't find it. AFAIK the pattern is always:
>> >         common: take lock
>> >         common: call per gic callback
>> >                 per gic callback: do stuff assuming lock held
>> >         common: release lock
>> >
>> > IOW the lock is only used from the common code?
>> >
>> Yes, lock is only used in common code and your pattern is correct.
>
> Why is gic.lock not alright?
>
gic.lock also protects some common code as well in the existing v2 driver.
So it is retained in common code and locking mechanism is not changed.

>> I made it separate patch as this is not trivial change
>>
>> > Ian.
>> >
>
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel