Re: [Xen-devel] [PATCH v3 03/16] xen/arm: make sgi handling generic

[Julien Grall <julien.grall@xxxxxxxxxx>]

On 04/15/2014 06:51 PM, Julien Grall wrote:
>>  void smp_send_state_dump(unsigned int cpu)
>> diff --git a/xen/include/asm-arm/gic.h b/xen/include/asm-arm/gic.h
>> index 5d8f7f1..d03b490 100644
>> --- a/xen/include/asm-arm/gic.h
>> +++ b/xen/include/asm-arm/gic.h
>> @@ -50,6 +50,10 @@
>>  #define GICD_SPENDSGIRN (0xF2C/4)
>>  #define GICD_ICPIDR2    (0xFE8/4)
>>  
>> +#define SGI_TARGET_LIST    0
>> +#define SGI_TARGET_OTHERS  1
>> +#define SGI_TARGET_SELF    2
>> +
> 
> You don't need to export it. It's used internally...

I forgot that it means to be used with both V2 and V3...

My remarks stay unchanged for the enum things.

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel