Re: [Xen-devel] [PATCH v4 2/3] x86/svn: Enable TSC scaling

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 16/04/14 02:27, Boris Ostrovsky wrote:
> TSC ratio enabling logic is inverted: we want to use it when we
> are running in native tsc mode, i.e. when d->arch.vtsc is zero.
>
> Also, since now svm_set_tsc_offset()'s calculations depend
> on vtsc's value, we need to call hvm_funcs.set_tsc_offset() after
> vtsc changes in tsc_set_info().
>
> In addition, with TSC ratio enabled, svm_set_tsc_offset() will
> need to do rdtsc. With that we may end up having TSCs on guest's
> processors out of sync. d->arch.hvm_domain.sync_tsc which is set
> by the boot processor can now be used by APs as reference TSC
> value instead of host's current TSC.
>
> Signed-off-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>

"svm" in the subject?

~Andrew

> ---
>  xen/arch/x86/hvm/hvm.c           |   15 ++++++++++-----
>  xen/arch/x86/hvm/svm/svm.c       |   15 +++++++++------
>  xen/arch/x86/hvm/vmx/vmx.c       |    2 +-
>  xen/arch/x86/hvm/vmx/vvmx.c      |    4 ++--
>  xen/arch/x86/hvm/vpt.c           |   16 ++++++++++------
>  xen/arch/x86/time.c              |   29 +++++++++++++++++++++++++++--
>  xen/include/asm-x86/hvm/domain.h |    6 ++++++
>  xen/include/asm-x86/hvm/hvm.h    |    8 +++++---
>  xen/include/asm-x86/msr.h        |    6 +++---
>  xen/include/xen/time.h           |    1 +
>  10 files changed, 74 insertions(+), 28 deletions(-)
>
>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel