Re: [Xen-devel] [PATCH v3 13/16] xen/arm: Add support for GIC v3

[Vijay Kilari <vijay.kilari@xxxxxxxxx>]

On Wed, Apr 16, 2014 at 2:13 AM, Julien Grall <julien.grall@xxxxxxxxxx> wrote:
> On 04/15/2014 12:17 PM, vijay.kilari@xxxxxxxxx wrote:
>> From: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxxxxxxxxxx>
>>
>> Add support for GIC v3 specification System register access(SRE)
>> is enabled to access cpu and virtual interface regiseters based
>
> s/regiseters/registers/
>
>> on kernel GICv3 driver.
>
> I think you miss some newline in this paragraph.
>
> What are the major changes with GICv3 from the kernel? Do you have a
> commit ID? (Will be easier to sync if an issue is found).
>
I have taken only some helper functions from Kernel driver.
I will update with commit-id in my next version.

>>
>> This patch adds only basic v3 support.
>
> What does mean basic? What is missing? What is there?

Still some more features are missing. I will plan for these later
Ex:
Locality Specific Peripheral Interrupts (LPIs)
Interrupt Translation Services (ITS)

>> Does not support Interrupt Translation support (ITS)
>>
>> Signed-off-by: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxxxxxxxxxx>
>> ---
>> + *
>> + * ARM Generic Interrupt Controller support v3 version
>> + * based on xen/arch/arm/gic-v2.c and kernel GICv3 driver
>> + *
>> + * Vijaya Kumar K <vijaya.kumar@xxxxxxxxxxxxxxxxxx>
>> + * Copyright (c) 2014 Cavium Inc.
>
> If it's based on the Linux drivers, I think you have to keep Marc's
> Copyright.
I have taken only few helper functions from kernel driver.
So I have mentioned based on.

>> +                if ( typer & GICR_TYPER_VLPIS )
>> +                    ptr += SZ_64K * 2; /* Skip VLPI_base + reserved page */
>> +            }
>> +        } while ( !(typer & GICR_TYPER_LAST) );
>> +    }
>> +
>> +    dprintk(XENLOG_WARNING, "CPU%d: mpidr %"PRIpaddr" has no 
>> re-distributor!\n",
>> +                  smp_processor_id(), mpidr);
>
> What happen if you don't have re-distributor?
>
  I think, we can't handle SGI & PPI's. As configuration and handling of these
is done in GICR region. May be I can change it to BUG_ON

> [..]
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel