Re: [Xen-devel] [PATCH v7 05/12] xen/arm: nr_lrs should be uint8_t

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2014-04-08 at 16:12 +0100, Stefano Stabellini wrote:
> A later patch is going to use uint8_t to keep track of LRs.
> Both GICv3 and GICv2 don't need any more than an uint8_t to keep track
> of the number of LRs.

Did you confirm that this doesn't lead to inefficient loading and
masking stuff on access?

> Signed-off-by: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> Acked-by: Julien Grall <julien.grall@xxxxxxxxxx>

If yes then:
Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Although TBH I'm not sure why unsigned int was so harmful here.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel