Re: [Xen-devel] [PATCH v3 12/16] xen/arm: split vgic driver into generic and vgic-v2 driver

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2014-04-15 at 16:47 +0530, vijay.kilari@xxxxxxxxx wrote:
> From: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxxxxxxxxxx>
> 
> Existing vGIC driver has both generic code and hw specific
> code. Segregate vGIC low level driver into vgic-v2.c and
> keep generic code in existing vgic.c file
> 
> some static generic functions in vgic.c is made as non-static
> so that these generic functions can be used in vGIC v2 driver.
> 
> vGIC v2 driver registers required callbacks to generic vGIC
> driver. This helps to plug in next version of vGIC drivers
> like vGIC v3

Please can you clarify that the intention here is that all domains use
the same version of vgic as the physical gic. Otherwise I'm going to ask
why these callbacks aren't domain specific.

> +struct vgic_ops {
> +    int (*vgic_vcpu_init)(struct vcpu *v);
> +    int (*vgic_domain_init)(struct domain *d);

The vgic prefix here is unnecessary.

> +    int (*read_priority)(struct vcpu *v, int irq);

get_irq_priority would be a better name I think.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel