Re: [Xen-devel] [PATCH v4 1/2] SVM: support data breakpoint extension registers

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 24.04.14 at 10:21, <Ian.Campbell@xxxxxxxxxxxxx> wrote:
> On Wed, 2014-04-16 at 15:33 +0100, Jan Beulich wrote:
>> --- a/xen/arch/x86/hvm/hvm.c
>> +++ b/xen/arch/x86/hvm/hvm.c
>> @@ -3080,6 +3080,9 @@ void hvm_cpuid(unsigned int input, unsig
>>          /* Only provide PSE36 when guest runs in 32bit PAE or in long mode 
> */
>>          if ( !(hvm_pae_enabled(v) || hvm_long_mode_enabled(v)) )
>>              *edx &= ~cpufeat_mask(X86_FEATURE_PSE36);
>> +        /* Hide data breakpoint extensions if the hardware has not support. 
> */
> 
> s/not/no/ is more grammatical.
> 
> Other than that for the tools bit (and I realise I overshot with that
> comment

In no way - I have no idea why I wrote "not" (fingers on autopilot?)...

>): Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Thanks, Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel