Re: [Xen-devel] [SeaBIOS] [PATCH v2] ld: don't hardcode "-melf_i386"

[Roger Pau Monné <roger.pau@xxxxxxxxxx>]

On 25/04/14 02:46, Kevin O'Connor wrote:
> On Wed, Apr 16, 2014 at 01:50:29PM +0100, Ian Campbell wrote:
>> On Wed, 2014-04-16 at 14:48 +0200, Idwer Vollering wrote:
>>> 2014-04-16 9:14 GMT+02:00 Roger Pau Monne <roger.pau@xxxxxxxxxx>:
>>>> On FreeBSD, the name of the emulation is "-melf_i386_fbsd", so allow
>>>> SeaBIOS to fetch the emulation to use from the environment variables.
>>>>
>>>> This allows SeaBIOS to compile on FreeBSD with gcc.
>>>>
>>>> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
>>>
>>> Acked-by: Idwer Vollering <vidwer@xxxxxxxxx>
>>>
>>> With the note that one needs to use ld from ports' binutils, not the 
>>> shipped ld:
>>
>> Which according to your debug output supports -melf_i386, so why this
>> patch in that case?
> 
> FYI, I didn't see a response on this question, so I've held off on
> applying this patch.

If using ld from FreeBSD base you have to pass
LD32BIT_FLAG=-melf_i386_fbsd. On the other hand, if using ld from ports,
you can either pass the same value, or use the default one (-melf_i386).
This is also needed for Illumos support:

http://marc.info/?l=xen-devel&m=139758558530393

So I don't see a reason for holding it off.

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel