Re: [Xen-devel] [PATCH v2 3/8] tools: arm: move magic pfns out of guest RAM region

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-04-25 at 13:09 +0100, Julien Grall wrote:
> 
> On 25/04/14 12:22, Ian Campbell wrote:
> > diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
> > index dd53c94..a94d16b 100644
> > --- a/xen/include/public/arch-arm.h
> > +++ b/xen/include/public/arch-arm.h
> > @@ -375,6 +375,8 @@ typedef uint64_t xen_callback_t;
> >   #define GUEST_GNTTAB_BASE 0xb0000000ULL
> >   #define GUEST_GNTTAB_SIZE 0x00020000ULL
> >
> > +#define GUEST_MAGIC_BASE  0xc0000000ULL
> > +
> 
> I'm wondering if we need to move NR_MAGIC_PAGES or add a comment in 
> arch-arm.h if someone wants to bump the number page magic page.
> 
> Or perhaps a BUG_ON in libxc to check at compilation time the hole is 
> large enought to hold all special pages.

I'll add GUEST_MAGIC_SIZE and a (BUILD_)BUG_ON to check against it.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel