Re: [Xen-devel] [libvirt] [PATCH] libxl: Support PV consoles

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-04-25 at 16:15 +0100, Daniel P. Berrange wrote:
> I think we can in fact just replace 'nserials' / 'serials' with
> 'nconsoles' / 'consoles' unconditionally.  If a guest has a
> traditional serial port, then this wil be duplicated into the
> 'def->consoles' array too. So soley looking at def->consoles[0]
> should be sufficient.

I did vaguely remember something about a thing being duplicated into a
another but not enough of the details to reach this conclusion. Thanks
for the tip.

> We can set console_type based on targetType
> eg I think this should work for both pv & hvm
> 
>     if (vm->def->nconsoles) {
>        chr = vm->def->consoles[0];
>        console_type = (chr->targetType == 
> VIR_DOMAIN_CHR_CONSOLE_TARGET_TYPE_SERIAL ?
>                        LIBXL_CONSOLE_TYPE_SERIAL : LIBXL_CONSOLE_TYPE_PV);
>     }

Yes I expect that will work, I'll check and then send an update patch.
This presumably gets us closer to being able to resolve this too:

    if (dev_name) {
        /* XXX support device aliases in future */
        virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
                       _("Named device aliases are not supported"));
        goto cleanup;
    }

Ian.




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel