Re: [Xen-devel] [PATCH 2/4 v2] x86/EPT: refine direct MMIO checking when determining EMT

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 28.04.14 at 09:59, <kevin.tian@xxxxxxxxx> wrote:
>>  From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
>> @@ -810,10 +811,7 @@ int epte_get_entry_emt(struct domain *d,
>>          return -1;
>>      }
>> 
>> -    if ( !iommu_enabled ||
>> -         (rangeset_is_empty(d->iomem_caps) &&
>> -          rangeset_is_empty(d->arch.ioport_caps) &&
>> -          !has_arch_pdevs(d)) )
>> +    if ( !need_iommu(d) && !cache_flush_permitted(d) )
> 
> &&->||

No, specifically not - we shouldn't force WB in either case.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel