Re: [Xen-devel] [PATCH] xen: workaround for 64-bit size/alignment bitops

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2014-04-28 at 11:13 +0100, David Vrabel wrote:
> On 28/04/14 10:13, Ian Campbell wrote:
> > On Sun, 2014-04-27 at 10:09 +0100, Vladimir Murzin wrote:
> >> diff --git a/drivers/xen/events/events_fifo.c 
> >> b/drivers/xen/events/events_fifo.c
> >> index 96109a9..bff9841 100644
> >> --- a/drivers/xen/events/events_fifo.c
> >> +++ b/drivers/xen/events/events_fifo.c
> >> @@ -66,7 +66,9 @@ static DEFINE_PER_CPU(struct evtchn_fifo_queue, 
> >> cpu_queue);
> >>  static event_word_t *event_array[MAX_EVENT_ARRAY_PAGES] __read_mostly;
> >>  static unsigned event_array_pages __read_mostly;
> >>  
> >> -#define BM(w) ((unsigned long *)(w))
> >> +
> >> +#define BM(w) (unsigned long *)((unsigned long)w & ~0x7UL)
> >> +#define EVTCHN_FIFO_BIT(b, w) (((unsigned long)w & 0x4UL) ? (EVTCHN_FIFO_ 
> >> ##b + 32) : EVTCHN_FIFO_ ##b)
> > 
> > A comment to describe why we jump through these hoops might be nice.
> > Apart from that: Reviewed-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> 
> I added a comment and made the fix conditional on !x86 and 64-bit (see below)
> and applied to stable/for-linus-3.15.

Excellent, thanks!



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel