Re: [Xen-devel] [PATCH 2/4] x86/boot: Early data should live in init.data

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 28/04/14 11:37, Jan Beulich wrote:
>>>> On 28.04.14 at 12:16, <andrew.cooper3@xxxxxxxxxx> wrote:
>> On 28/04/14 11:08, Jan Beulich wrote:
>>>>>> On 25.04.14 at 21:50, <andrew.cooper3@xxxxxxxxxx> wrote:
>>>> --- a/xen/arch/x86/boot/head.S
>>>> +++ b/xen/arch/x86/boot/head.S
>>>> @@ -32,11 +32,17 @@ ENTRY(start)
>>>>          /* Checksum: must be the negated sum of the first two fields. */
>>>>          .long   -(MULTIBOOT_HEADER_MAGIC + MULTIBOOT_HEADER_FLAGS)
>>>>  
>>>> -        .section .init.text, "ax"
>>>> +        .section .init.data, "aw", @progbits
>>>> +
>>>> +gdt_boot_descr:
>>>> +        .word   6*8-1
>>>> +        .long   sym_phys(trampoline_gdt)
>>> While at it, how about putting this on a 2 mod 4 boundary?
>> Yes, and the strings below into .rodata
> Actually not just them - the construct above is read-only too afaict.
>
> Jan

Yes - I noticed as much when starting to implement the changed.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel