Re: [Xen-devel] [PATCH v2 2/3] x86/boot: Move some __high_start code and data into init sections

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 28.04.14 at 15:06, <andrew.cooper3@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/boot/x86_64.S
> +++ b/xen/arch/x86/boot/x86_64.S
> @@ -29,7 +29,11 @@
>  
>          test    %ebx,%ebx
>          jnz     start_secondary
> +        jmp     start_bsp
>  
> +        .section .init.text, "ax", @progbits
> +
> +GLOBAL(start_bsp)

I'm sorry, I'm afraid I overlooked this in v1 - why GLOBAL()? (The other
two patches look fine to me now, so no need to re-send those in case
this one needs changing.)

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel