Re: [Xen-devel] [PATCH RFC 23/23] build: export linker emulation parameter to SeaBIOS

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2014-04-16 at 16:13 +0200, Roger Pau Monne wrote:
> Signed-off-by: Roger Pau Monnà <roger.pau@xxxxxxxxxx>
> Cc: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> ---
>  tools/firmware/Makefile |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/tools/firmware/Makefile b/tools/firmware/Makefile
> index dcb56e5..092f1bc 100644
> --- a/tools/firmware/Makefile
> +++ b/tools/firmware/Makefile
> @@ -17,6 +17,10 @@ SUBDIRS-$(CONFIG_ROMBIOS) += vgabios
>  SUBDIRS-$(CONFIG_ROMBIOS) += etherboot
>  SUBDIRS-y += hvmloader
>  
> +LD32BIT-$(CONFIG_FreeBSD) := -melf_i386_fbsd
> +LD32BIT-$(CONFIG_NetBSD) := -melf_i386
> +LD32BIT-$(CONFIG_Linux) := -melf_i386

Can we do this as

LD32BIT-$(CONFIG_FreeBSD) := LD32BIT_FLAG=-m....

Then pass $(LD32BIT-y) to $(MAKE).

IOW avoid needlessly overriding it.

Given that most OSes seem to support melf as well as their native
emulation I don't suppose you want to take this up with the FreeBSD
folks?



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel