[Xen-devel] is it ok to disable qemu-xen gtk feature by default?

["Dennis Lan (dlan)" <dennis.yxun@xxxxxxxxx>]

HI ALL:
  I've recently bugged by file collisions in Gentoo [1], I spent  few
time to do the investigation.
  Those files only installed while qemu's gtk feature[2] is enabled.
so my question here is: can we disable gtk feature here[3] in xen? or
ask in another ways, is the qemu gtk feature useful for xen? if I
understand correctly, qemu is doing only for io emulation in xen..
  Thanks.
Lan


[1] https://bugs.gentoo.org/show_bug.cgi?id=508302
* package app-emulation/xen-tools-4.4.0-r1 NOT merged
 *
 * Detected file collision(s):
 *
 *      /usr/share/locale/hu/LC_MESSAGES/qemu.mo
 *      /usr/share/locale/it/LC_MESSAGES/qemu.mo
 *      /usr/share/locale/tr/LC_MESSAGES/qemu.mo
 *      /usr/share/locale/fr_FR/LC_MESSAGES/qemu.mo
 *      /usr/share/locale/de_DE/LC_MESSAGES/qemu.mo
 *
 * Searching all installed packages for file collisions...
 *
 * Press Ctrl-C to Stop
 *
 * app-emulation/qemu-1.6.0-r1:0::gentoo
 *      /usr/share/locale/de_DE/LC_MESSAGES/qemu.mo
 *      /usr/share/locale/fr_FR/LC_MESSAGES/qemu.mo
 *      /usr/share/locale/hu/LC_MESSAGES/qemu.mo
 *      /usr/share/locale/it/LC_MESSAGES/qemu.mo
 *      /usr/share/locale/tr/LC_MESSAGES/qemu.mo

[2] xen-4.4.0/tools/qemu-xen/Makefile
350 ifeq ($(CONFIG_GTK),y)
351        $(MAKE) -C po $@
352 endif

[3] patch to disable qemu gtk feature in xen

diff --git a/tools/Makefile b/tools/Makefile
index 00c69ee..12ce6cb 100644
--- a/tools/Makefile
+++ b/tools/Makefile
@@ -203,6 +203,7 @@ subdir-all-qemu-xen-dir: qemu-xen-dir-find
                --disable-kvm \
                --disable-docs \
                --disable-guest-agent \
+               --disable-gtk \
                --python=$(PYTHON) \
                $(IOEMU_CONFIGURE_CROSS); \
        $(MAKE) all

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel