Re: [Xen-devel] [PATCH v3 4/9] Clear AC bit in RFLAGS to protect Xen itself by SMAP

["Wu, Feng" <feng.wu@xxxxxxxxx>]

> -----Original Message-----
> From: Andrew Cooper [mailto:andrew.cooper3@xxxxxxxxxx]
> Sent: Tuesday, April 29, 2014 6:32 PM
> To: Wu, Feng
> Cc: Jan Beulich; ian.campbell@xxxxxxxxxx; Dong, Eddie; Nakajima, Jun; Tian,
> Kevin; xen-devel@xxxxxxxxxxxxx
> Subject: Re: [PATCH v3 4/9] Clear AC bit in RFLAGS to protect Xen itself by 
> SMAP
> 
> On 29/04/14 11:29, Wu, Feng wrote:
> >
> >> -----Original Message-----
> >> From: Jan Beulich [mailto:JBeulich@xxxxxxxx]
> >> Sent: Tuesday, April 29, 2014 5:48 PM
> >> To: Wu, Feng
> >> Cc: andrew.cooper3@xxxxxxxxxx; ian.campbell@xxxxxxxxxx; Dong, Eddie;
> >> Nakajima, Jun; Tian, Kevin; xen-devel@xxxxxxxxxxxxx
> >> Subject: RE: [PATCH v3 4/9] Clear AC bit in RFLAGS to protect Xen itself by
> SMAP
> >>
> >>>>> On 29.04.14 at 11:27, <feng.wu@xxxxxxxxx> wrote:
> >>> May I move the definition of SAVE_ALL (or more related code, such as,
> >>> SAVE_VOLATILE, etc.) from " xen/include/asm-x86/x86_64/asm_defns.h "
> to "
> >>> xen/include/asm-x86/asm_defns.h ", since I got an build error after adding
> a
> >>> parameter to marco SAVE_ALL like this, which makes me think it should be
> >>> defined after ASM_CLAC?
> >> No problem (and in fact I wouldn't mind you merging all of
> >> x86_64/asm_defns.h into the other file - that due at some point
> >> anyway), but I'm afraid we'd want this to be yet another separate
> >> prerequisite patch - not sure if you're up to that, or if you wouldn't
> >> find it simpler to keep SAVE_ALL being a C macro then.
> > I am fine with the merging task. But Is there anything hard to handle while
> merging x86_64/asm_defns.h to asm_defns.h, I am wondering
> > why x86_64/asm_defns.h is there for a long time.
> 
> Because x86_32/asm_defns.h used to exist when we supported building Xen
> as 32bit.  I wouldn't have thought there is anything problematic to be
> encountered while merging the files.
> 
> ~Andrew

Okay, I got it. Thanks!

Thanks,
Feng

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel