Re: [Xen-devel] [PATCH] tools/mfn-dump: Fixes to 'dump-p2m'

[Dario Faggioli <dario.faggioli@xxxxxxxxxx>]

On gio, 2014-04-24 at 22:06 +0100, Andrew Cooper wrote:
> * Don't walk off the end of p2m_table under the mistaken impression that it
>   contains toolstack unsigned longs.  Despite its array type it contains guest
>   unsigned longs so unconditionally needs casting to the guest width to use
>   correctly.  Furthermore, a 64bit toolstack must be extra careful when it
>   finds a 32bit guest's INVALID_MFN.
> 
> * Drop 'mapped' and 'pinned' descriptions.  This are both bogus, including all
>   uses of the is_mapped() macro.
> 
Just a question, what do you mean by 'bogus' here? About pinned, I think
I see it, and I like the way you put it in the patch. About 'mapped' and
is_mapped()? Do you mean to say it's not useful information here?

Again, just curious.

> * Rearrange the type name printing to be more concise.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> CC: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
> CC: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> CC: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
>
In any case, I think this is all correct and I like the new look of the
code, so:

Reviewed-by: Dario Faggioli <dario.faggioli@xxxxxxxxxx>

Sorry again for the delay,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel