[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2] tools: require OCaml version 3.09.3 or greater

On 04/30/14 11:10, Ian Campbell wrote:
On Wed, 2014-04-30 at 16:04 +0100, Ian Jackson wrote:
Ian Campbell writes ("Re: [Xen-devel] [PATCH v2] tools: require OCaml version 3.09.3 
or greater"):
I have this on my list of things for backport, but it's comes under your
umbrella. What do you think?
I looked through the past email thread and I can't see /why/ this
patch was applied.  The commit message doesn't explain either!

Rather than me digging through list archives, perhaps someone could
enlighten me ?  If I ever knew I have forgotten ...
 From memory something or other didn't compile with the ocaml in RHEL5,
which was older.

I was the person that found an ocaml change that did not compile in RHEL5 
(OCaml version 3.09.3)

This was done to help catch build errors.  The fix for RHEL5 was:

[BUGFIX][PATCH 1/1] xenlight_stubs.c: Allow it to build with ocaml 3.09.3


+ * Starting with ocaml-3.09.3, CAMLreturn can only be used for ``value''
+ * types. CAMLreturnT was only added in 3.09.4, so we define our own
+ * version here if needed.
+ */

Hope this helps.
   -Don Slutz


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.