Re: [Xen-devel] [PATCH V5 29/32] xl: use "libxl-json" format

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, May 20, 2014 at 04:39:42PM +0100, Ian Jackson wrote:
> Ian Campbell writes ("Re: [PATCH V5 29/32] xl: use "libxl-json" format"):
> > On Tue, 2014-05-20 at 16:11 +0100, Ian Jackson wrote:
> > > Firstly, I think this editing of libxl's copy of domain config way is
> > > a layering violation.
> > > 
> > > But it ought to be unnecessary, because either libxl_domain_rename
> > 
> > That would lend credence to the idea that these functions ought to be
> > internal to the library, or at least the store one should (get is still
> > useful to applications I suppose, e.g. xl list).
> 
> Indeed.
> 
> > > or "libxl_load_domain_configuration" should deal with it.  I would
> > > much prefer the latter, as that results in the domain name being
> > > stored only in one place.
> > 
> > You mean libxl_load_dmoain_config should have special handling for
> > domains names ending --incoming (or --.* perhaps)? That doesn't seem
> > right, I suspect you meant something else.
> 
> No, that's not what I mean.
> 
> I mean that libxl_load_domain_config[1] should obtain the actual
> domain name from xenstore, the same way that libxl_domid_to_name does,
> and put it into the retreived configuration.
> 
> Ian.
> 
> [1] should probably be called libxl_get_domain_config or something
> like that, because "load" might suggest "loading" the config into the
> system to make it effective.

(I should've looked at the whole thread before sending my previous
email)

In this case the stored version has "--incoming" suffix. I would still
prefer we have everything in one place, that is, in the stored JSON
version, so that other functions only need to use "get" to get hold of
the current configuration.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel