Re: [Xen-devel] [PATCH] xen/arm: remove check for generic timer support for arm64

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2014-06-02 at 15:13 +0100, Julien Grall wrote:
> On 06/02/2014 03:11 PM, Ian Campbell wrote:
> > On Mon, 2014-06-02 at 19:38 +0530, Vijay Kilari wrote:
> >> On Mon, Jun 2, 2014 at 7:32 PM, Ian Campbell <Ian.Campbell@xxxxxxxxxx> 
> >> wrote:
> >>> On Mon, 2014-06-02 at 19:29 +0530, Vijay Kilari wrote:
> >>>> However generic timer is required for aarch64 mode.
> >>>
> >>> Do you have an ARM ARM reference for that? If true it would indeed
> >>> simplify things, but I was unable to find a statement along those
> >>> lines...
> >>
> >>   Sorry, I too didn't not get any reference for this.
> >> But in arm64 where Aarch32 is optional, why should one rely on Aarch32
> >> feature register
> >> if generic timer is anyway required for Aarch64
> > 
> > We shouldn't, the bug is that we are checking the AArch32 feature
> > register instead of the AArch64 one in this case (see the rest of this
> > thread).
> 
> AArch64 doesn't have a similar feature bit in AA64PFR*.

Damn, I was looking at ID_PFR (the 32-bit version) again!

If there is no AArch64 feature bit then surely this must be a
non-optional extension. Just need to find the actual reference for that!

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel