Re: [Xen-devel] [PATCH v2] xen-blkback: defer freeing blkif to avoid blocking xenwatch

[Matt Wilson <msw@xxxxxxxxx>]

On Tue, May 13, 2014 at 10:32:36AM +0100, David Vrabel wrote:
> On 12/05/14 20:25, Valentin Priescu wrote:
> > From: Valentin Priescu <priescuv@xxxxxxxxxx>
> > 
> > Currently xenwatch blocks in VBD disconnect, waiting for all pending I/O
> > requests to finish. If the VBD is attached to a hot-swappable disk, then
> > xenwatch can hang for a long period of time, stalling other watches.
> > 
> [...]
> > 
> > With this patch, when there is still pending I/O, the actual disconnect
> > is done by the last reference holder (last pending I/O request). In this
> > case, xenwatch doesn't block indefinitely.
> 
> Reviewed-by: David Vrabel <david.vrabel@xxxxxxxxxx>
> 
> > Signed-off-by: Valentin Priescu <priescuv@xxxxxxxxxx>
> > Reviewed-by: Steven Kady <stevkady@xxxxxxxxxx>
> > Reviewed-by: Steven Noonan <snoonan@xxxxxxxxxx>
> > Acked-by: Matt Wilson <msw@xxxxxxxxxx>
> 
> Not sure Acked-by by a non-maintainer makes much sense. Matt, did you
> mean Reviewed-by here instead?

Apologies for the late reply.

I had not performed a thorough review of this form of the patch, but I
wanted to show that I think that the patch is needed and should be
applied. Acked-by: isn't only used by maintainers.

--msw

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel