Re: [Xen-devel] [PATCH 2/4] mini-os: Tidied up code

[Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>]

Thomas Leonard, le Mon 02 Jun 2014 18:49:55 +0100, a écrit :
> +#define DEBUG(_f, _a...) \
> +    printk("MINI_OS(file=gntmap.c, line=%d) " _f "\n", __LINE__, ## _a)

While at it, this could use %s and __func__ to automatically print the
function name.

> --- a/extras/mini-os/include/x86/arch_spinlock.h
> +++ b/extras/mini-os/include/x86/arch_spinlock.h
> @@ -61,7 +61,7 @@
>  
>  static inline void _raw_spin_unlock(spinlock_t *lock)
>  {
> -     char oldval = 1;
> +     char oldval = ARCH_SPIN_LOCK_UNLOCKED;

It looks a bit odd to the compiler, but it's valid and better, indeed.

Apart from the __func__ nitpicking,

Acked-by: Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>

Samuel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel