Re: [Xen-devel] [PATCH v4 13/16] xen/arm: Add support for GIC v3

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Tue, 3 Jun 2014, Ian Campbell wrote:
> > > +static void gicv3_restore_state(const struct vcpu *v)
> > > +{
> > > +    gicv3_restore_lr(gicv3_info.nr_lrs, v);
> > > +    restore_aprn_regs(&v->arch.gic);
> > > +    WRITE_SYSREG32(v->arch.gic.v3.vmcr, ICH_VMCR_EL2);
> > > +}
> > 
> > Shouldn't we restore vmcr first? Before writing to the LRs?
> 
> Can you remind me of the dependency?

The ICH_VMCR_EL2 settings affect the LRs. For example VEOIM (bit 9),
VFIQEn (bit 3), VAckCtl (bit 2), VENG1 (bit 1) and VENG0 (bit 0).

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel