[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 06/17] libxc: remove broken endianess gate on lz4 decompressor

On Mon, 2014-06-02 at 17:08 +0200, Roger Pau Monne wrote:
> The lz4 decompressor had wrongly implemented a gate between
> little-endian and big-endian versions of get_unaligned_le{16/32},
> which turns out to be broken on all architectures supported by Xen,
> because __LITTLE_ENDIAN is not defined. Instead of trying to fix
> this, just implement the little-endian version and remove the switch.

AFAICT the so called "little endian" versions are perfectly fine for be
too -- since they use le32_to_cpup.

> Signed-off-by: Roger Pau Monnà <roger.pau@xxxxxxxxxx>
> Cc: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.