[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH v4 0/3] Add max-ram-below-4g (was Add pci_hole_min_size machine option)

Changes v3 to v4:
  Split out #2 "GlobalProperty: Display warning about unused -global"
  rebase on e00fcfe (origin/master)
  rename xen-all to xen-hvm

  Adjust #1 "xen-hvm: Fix xen_hvm_init() to adjust pc memory layout"
    Switch Acked-by & Signed-off-by
    rebase on master

  Rework #3 "xen-hvm: Pass is_default to xen_hvm_init":
    To pass is_default instead of max_ram_below_4g.
    Also did not add "Acked-by: Stefano Stabellini" since code changed a lot.

  Andreas FÃrber:
    all: Remove dot at end of subject
    #3 "xen-hvm: Pass is_default to xen_hvm_init"
      Adjust comment formatting.

  Andreas FÃrber, Paolo Bonzini, Marcel Apfelbaum:
    rework to use "opts per machine"
    Drop old #3, new #2.

Changes v2 to v3:
  Stefano Stabellini:
    Acked-by #1 "xen-all: Fix xen_hvm_init() to adjust pc memory"
    Adjust for code readability #4 "xen-all: Pass max_ram_below_4g to 
       Set max_ram_below_4g always and use it to calculate above_4g_mem_size,

Changes v1 to v2:
  Michael S. Tsirkin:
    Rename option.
    Only add it to machine types that support it.
  Split into 4 parts.

1/4 -- xen-all: Fix xen_hvm_init() to adjust pc memory layout

  This looks to be a possible bug that has yet to be found.
  below_4g_mem_size and above_4g_mem_size are stored in PcGuestInfo
  (pc_guest_info_init) which are currently not "correct".  This and
  4/4 change the same lines.

2/4 -- GlobalProperty: Display warning about unused -global

    My testing showed that setting a global property on an object
    that is not used is not reported at all.  This is added to help
    when the new global is set but not used.  The negative not_used
    was picked so that all static objects are assumed to be used
    even when they are not.

3/4 -- pc & q35: Add new object pc-memory-layout

  The objects that it might make sense to add this property to all
  get created too late.  So add a new object just to hold this
  property.  Name it so that it is expected that only pc (and q35)
  machine types support it.

4/4 -- xen-all: Pass max_ram_below_4g to xen_hvm_init

  Seprate the xen only part of the change.  Currectly based on patch 1/4

Don Slutz (3):
  xen-hvm: Fix xen_hvm_init() to adjust pc memory layout
  pc & q35: Add new machine opt max-ram-below-4g
  xen-hvm: Pass is_default to xen_hvm_init

 hw/core/machine.c                 |  44 +++++++++++++++
 hw/i386/pc.c                      |  22 ++++++++
 hw/i386/pc_piix.c                 | 115 +++++++++++++++++++++++++++++++++-----
 hw/i386/pc_q35.c                  |  65 ++++++++++++++++-----
 include/hw/boards.h               |   1 +
 include/hw/i386/pc-machine-opts.h |  46 +++++++++++++++
 include/hw/xen/xen.h              |   3 +-
 vl.c                              |   5 ++
 xen-hvm-stub.c                    |   3 +-
 xen-hvm.c                         |  46 ++++++++-------
 10 files changed, 300 insertions(+), 50 deletions(-)
 create mode 100644 include/hw/i386/pc-machine-opts.h


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.