Re: [Xen-devel] [Linaro-uefi] [PATCH] xen: arm: implement generic multiboot compatibility strings (Was: Re: The GRUB multiboot support patch for aarch64(V3.1))

[Ian Campbell <ijc@xxxxxxxxxxxxxx>]

On Thu, 2014-06-05 at 18:05 +0100, Leif Lindholm wrote:
> On Thu, Jun 05, 2014 at 05:55:31PM +0100, Ian Campbell wrote:
> > > > -    if ( fdt_node_check_compatible(fdt, node, "xen,linux-zimage") == 0 
> > > > )
> > > > +    if ( fdt_node_check_compatible(fdt, node, "xen,linux-zimage") == 0 
> > > > ||
> > > > +         fdt_node_check_compatible(fdt, node, 
> > > > "multiboot,linux-zimage") == 0 )
> > > 
> > > While we are modifying the protocol, "linux-zImage" is confusing in the
> > > name. Actually we can use it for an ELF, another OS... I don't think Xen
> > > will change his behavior depending of the DOM0 image.
> > 
> > zImage defines the boot protocol to use. Since the protocol is defined
> > by Linux as zImage I think that is the appropriate name, if some other
> > OS wants to mimic Linux then fine. But if we end up supporting some OS
> > with its own  boot protocol which doesn't match Linux's then that should
> > have a distinct name of its own.
> 
> Actually, there is no zImage support in arm64 - only Image.

Right, that's a slight wrinkle in the naming. arm64's image is
essentially equivalent (from a calling into it PoV) to zImage, it
doesn't seem worth dupping the name here.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel