Re: [Xen-devel] [PATCH v10 0/5] Remus netbuffer: Network buffering support

[Hongyang Yang <yanghy@xxxxxxxxxxxxxx>]

On 06/06/2014 12:12 AM, Ian Jackson wrote:
> Yang Hongyang writes ("[PATCH v10 0/5] Remus netbuffer: Network buffering 
> support"):
> > the code is also hosted on github:
> >
> > url: https://github.com/laijs/xen
> > branch: remus-0605
> I see that this branch contains a commit "remus drbd: Implement remus
> drbd replicated disk" which is not in the 5-patch series you posted.
> I guess that that commit was added later - I can see it in my inbox.
>
> If you find the need to add a new patch to a series and update the
> already-published git branch, you should send a heads-up to the
> recipients of your 0/N email.  When you do this it would be better not
> to reuse the existing published git ref name, but to make a new one,
> unless you do the followup very quickly after the initial email.
>
> This is useful because the committers and reviewers rely on the two
> versions of the series (available via git, and via email) being
> identical.
>
> Also, if you send the new patch as N+1/N, eg, in this case
>    Subject: [PATCH v10 6/5] remus drbd: Implement remus drbd replicated disk
> then it becomes a bit clear that it's supposed to tie into the series.
>
> I will review your drbd patch as part of the series.
Hi Ian, thanks for the review. will combine the drbd and netbuffer patchs
into one patchset in the next version.

> Thanks,
> Ian.
> .
--
Thanks,
Yang.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel