Re: [Xen-devel] [PATCH v4 10/16] xen/arm: move vgic defines to vgic header file

[Vijay Kilari <vijay.kilari@xxxxxxxxx>]

Hi Julien,

On Tue, May 27, 2014 at 5:19 PM, Julien Grall <julien.grall@xxxxxxxxxx> wrote:
> Hi Vijay,
>
> On 05/26/2014 11:26 AM, vijay.kilari@xxxxxxxxx wrote:
>> diff --git a/xen/include/asm-arm/gic.h b/xen/include/asm-arm/gic.h
>> index f4c467a..2aadcb6 100644
>> --- a/xen/include/asm-arm/gic.h
>> +++ b/xen/include/asm-arm/gic.h
>> @@ -185,13 +185,6 @@ struct gic_lr {
>>
>>  extern int gic_hw_version(void);
>>
>> -extern int domain_vgic_init(struct domain *d);
>> -extern void domain_vgic_free(struct domain *d);
>> -
>> -extern int vcpu_vgic_init(struct vcpu *v);
>> -
>> -extern void vgic_vcpu_inject_irq(struct vcpu *v, unsigned int irq);
>> -extern void vgic_clear_pending_irqs(struct vcpu *v);
>>  extern struct pending_irq *irq_to_pending(struct vcpu *v, unsigned int irq);
>
> irq_to_pending is also a VGIC function. Can you move it to vgic.h?

   OK. I missed it. I can move it.
   But when I  move this to vgic.h file, there are compilation errors.
   The issue is pending_irq structure is defined in asm/domain.h file
   so domain.h should be included in gic.h. However domain.h needs gic.h
   for gic_state definition so domain.h depends on gic.h and gic.h depends on
   domain.h.

   I propose to move pending_irq structure to gic.h or vgic.h from domain.h

Regards
Vijay

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel