Re: [Xen-devel] [PATCH v7 01/19] common/symbols: Export hypervisor symbols to privileged guest

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 06.06.14 at 19:39, <boris.ostrovsky@xxxxxxxxxx> wrote:
> --- a/xen/include/public/platform.h
> +++ b/xen/include/public/platform.h
> @@ -527,6 +527,24 @@ struct xenpf_core_parking {
>  typedef struct xenpf_core_parking xenpf_core_parking_t;
>  DEFINE_XEN_GUEST_HANDLE(xenpf_core_parking_t);
>  
> +#define XENPF_get_symbol   61
> +struct xenpf_symdata {
> +    /* IN variables */
> +    uint32_t namelen; /* size of 'name' buffer */

I think if you want this to be an IN it should be named "namesize"
or "namesz"; when being "namelen" one wold naturally expect it
to be an IN/OUT (which I think I'd prefer).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel