Re: [Xen-devel] [PATCH v6 04/18] libxl: libxl_uuid_copy now takes a ctx argument

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2014-06-09 at 13:43 +0100, Wei Liu wrote:
> diff --git a/tools/libxl/libxl.h b/tools/libxl/libxl.h
> index 20aa875..d14f25f 100644
> --- a/tools/libxl/libxl.h
> +++ b/tools/libxl/libxl.h
> @@ -319,13 +319,15 @@
>  
>  #include <xentoollog.h>
>  
> +typedef struct libxl__ctx libxl_ctx;

Looks like you didn't move the existing one, but instead added a second?

> diff --git a/tools/libxl/libxl_uuid.c b/tools/libxl/libxl_uuid.c
> index ecc29c7..cb8546a 100644
> --- a/tools/libxl/libxl_uuid.c
> +++ b/tools/libxl/libxl_uuid.c
> @@ -14,7 +14,7 @@
>  
>  #include "libxl_osdeps.h" /* must come before any other headers */
>  
> -#include <libxl_uuid.h>
> +#include <libxl_internal.h>
>  
>  #include "libxl_internal.h"

I'm getting deja vu ;-)

Other than those two things looks good. With them resolved:
Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel