[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v6 03/18] xl / libxl: push VCPU affinity pinning down to libxl

On Mon, 2014-06-09 at 13:43 +0100, Wei Liu wrote:
> diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl
> index 0ea0464..4765fb6 100644
> --- a/tools/libxl/libxl_types.idl
> +++ b/tools/libxl/libxl_types.idl
> @@ -305,6 +305,7 @@ libxl_domain_build_info =
> Struct("domain_build_info",[
>      ("avail_vcpus",     libxl_bitmap),
>      ("cpumap",          libxl_bitmap),
>      ("nodemap",         libxl_bitmap),
> +    ("vcpu_affinity",   Array(libxl_bitmap, "num_vcpumaps")),

Looking at one of Dario's patches I became confused about how this new
field relates to the existing cpumap field.

Am I right that the new field is just a per-vcpu version of the old
(which only allows you to set the affinity of every vcpu together)?

Can this relationship be mentioned in the commit message and/or comments

I also wonder if the name could be changed to better reflect this
relationship, but I can't actually think of a good name. cpumap_FOO
where FOO has connotations of per-vcpu/listiness.

I also just noticed that this change violates the following from
  idl.Array.len_var contains an idl.Field which is added to the parent
  idl.Aggregate and will contain the length of the array. The field
  MUST be named num_ARRAYNAME.


>      ("numa_placement",  libxl_defbool),
>      ("tsc_mode",        libxl_tsc_mode),
>      ("max_memkb",       MemKB),

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.