Re: [Xen-devel] [v7 PATCH 08/10] xl: enable getting and setting soft

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2014-06-10 at 02:45 +0200, Dario Faggioli wrote:

$subject is truncated?

> +#define hard_aff_str (argv[optind+2])
> +#define soft_aff_str (argv[optind+3])

const char *foo = argv[...] please.

> +    /*
> +     * Hard affinity is always present. However, if it's "-", all we need
> +     * is passing a NULL pointer to the libxl_set_vcpuaffinity() call below.
> +     */
> +    if (!strcmp(hard_aff_str, "-"))
> +        hard = NULL;
> +    else if (vcpupin_parse(hard_aff_str, &cpumap))

Perhaps consider consistently using hard instead of &cpumap sometimes
(likewise below for soft). That seems like it might be clearer (the
cpumap* are really just stack vars in lieu of a malloc).

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel