Re: [Xen-devel] [v7 PATCH 07/10] libxl: get and set soft affinity

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2014-06-10 at 16:39 +0100, George Dunlap wrote:

> > diff --git a/tools/libxl/libxl.h b/tools/libxl/libxl.h
> > index 80947c3..e549db8 100644
> > --- a/tools/libxl/libxl.h
> > +++ b/tools/libxl/libxl.h
> > @@ -82,6 +82,15 @@
> >   #define LIBXL_HAVE_DOMAIN_NODEAFFINITY 1
> >   
> >   /*
> > + * LIBXL_HAVE_SOFT_AFFINITY indicates that a 'cpumap_soft'
> > + * field (of libxl_bitmap type) is present in:
> > + *  - libxl_vcpuinfo, containing the soft affinity of a vcpu;
> > + *  - libxl_domain_build_info, for setting the soft affinity of
> > + *    all vcpus while creating the domain.
> > + */
> > +#define LIBXL_HAVE_SOFT_AFFINITY 1
> 
> Did we say we were going to move these to where the actual change was 
> happening (say, down in the libxl_set_vcpuaffinity definitions)?  I'm OK 
> either way.

I'm not sure we reached consensus on that. I'd like to do this. Although
in this specific case it isn't clear since it affects two or more
places...

In any case I think it is fine for new patches to follow the existing
pattern until we decide.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel