[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 5/6] libxl: allow a generation ID to be specified at domain creation

On Tue, 2014-06-10 at 18:59 +0100, David Vrabel wrote:
> On 10/06/14 12:01, Ian Campbell wrote:
> > On Tue, 2014-06-03 at 14:15 +0100, David Vrabel wrote:
> > Should we consider calling the API field name something more specific,
> > like "ms_vgid"? I'm thinking of the case where some other OS vendor
> > reinvents the wheel. (I don't care about the internals, just the API).
> generation_id matches the platform/generation-id xenstore key so I would
> keep the libxl field name as-is.

One is an internal implementation detail (we can update libx? and
hvmloader in parallel if we have to) while the other is a stable API.

> > Do you not need to worry about endianess when memcpy'ing out of a uuid?
> No. The conversion of uuid to the two 64-bit integers is arbitrary, it
> need only be consistent.  The integers in guest memory are in native
> endianness.

OK. I was wondering if we might want to preserve the byte order so as
not to trample any UUID format which is used (i.e. the stuff described
 ). Or even just be sure that what libxl logs and what is observed in the guest 
matched (e.g. for debug purposes).


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.