Re: [Xen-devel] [PATCH v4 14/16] xen/arm: Add virtual GICv3 support

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Wed, 11 Jun 2014, Vijay Kilari wrote:
> Hi Stefano,
> 
> On Mon, Jun 2, 2014 at 9:20 PM, Stefano Stabellini
> <stefano.stabellini@xxxxxxxxxxxxx> wrote:
> > On Mon, 26 May 2014, vijay.kilari@xxxxxxxxx wrote:
> >> +    case GICD_IROUTER ... GICD_IROUTER31:
> >> +        /* SGI/PPI is RES0 */
> >> +        goto write_ignore_64;
> >> +    case GICD_IROUTER32 ... GICD_IROUTERN:
> >> +        if ( dabt.size != DABT_DOUBLE_WORD ) goto bad_width;
> >> +        rank = vgic_irq_rank(v, 64, gicd_reg - GICD_IROUTER, 
> >> DABT_DOUBLE_WORD);
> >> +        if ( rank == NULL) goto write_ignore;
> >> +        vgic_lock_rank(v, rank);
> >> +        rank->v3.irouter[REG_RANK_INDEX(64,
> >> +                      (gicd_reg - GICD_IROUTER), DABT_DOUBLE_WORD)] = *r;
> >> +        vgic_unlock_rank(v, rank);
> >> +        return 1;
> >
> > Similarly to
> >
> > http://marc.info/?l=xen-devel&m=140104126710713
> 
> Shall we handle this patch separately on top of this series instead of
> including this changes in the first version of vgic-v3.c?

I am fine with not having a complete implementation of GICD_IROUTER* in
the first version of the series.

In that case you might want to write_ignore any writes to GICD_IROUTER32
... GICD_IROUTERN.


> > We should ignore any writes to GICD_IROUTER*.
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel