Re: [Xen-devel] [PATCH v4 3/4] xen/arm: support irq delivery to vcpu > 0

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Tue, 10 Jun 2014, Ian Campbell wrote:
> > diff --git a/xen/arch/arm/irq.c b/xen/arch/arm/irq.c
> > index a33c797..0fad647 100644
> > --- a/xen/arch/arm/irq.c
> > +++ b/xen/arch/arm/irq.c
> > @@ -175,8 +175,7 @@ void do_IRQ(struct cpu_user_regs *regs, unsigned int 
> > irq, int is_fiq)
> >          desc->status |= IRQ_INPROGRESS;
> >          desc->arch.eoi_cpu = smp_processor_id();
> >  
> > -        /* XXX: inject irq into all guest vcpus */
> > -        vgic_vcpu_inject_irq(d->vcpu[0], irq);
> > +        vgic_vcpu_inject_irq(vgic_get_target_vcpu(d->vcpu[0], irq), irq);
> 
> Would it make sense to push vgic_get_target_vcpu down into
> vgic_vcpu_inject_irq rather than have all callers need to do it?
> 
> I'm also wondering if vgic_get_target_vcpu shouldn't take d and not v.

That could be a good idea.

> Does this do the right thing for PPIs? vgic_get_target_vcpu will just
> lookup vcpu0's target, not the actual expected target, won't it?
> (something else must deal with this, or it'd be broken already I
> suppose)

As Julien wrote, we don't support routing PPIs to guests.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel