Re: [Xen-devel] [PATCH] net: xen-netback: include linux/vmalloc.h again

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Jun 11, 2014 at 03:19:01PM -0700, David Miller wrote:
> From: Wei Liu <wei.liu2@xxxxxxxxxx>
> Date: Tue, 10 Jun 2014 09:44:54 +0100
> 
> > On Tue, Jun 10, 2014 at 10:34:36AM +0200, Arnd Bergmann wrote:
> >> commit e9ce7cb6b107 ("xen-netback: Factor queue-specific data into
> >> queue struct") added a use of vzalloc/vfree to interface.c, but
> >> removed the #include <linux/vmalloc.h> statement at the same time,
> >> which causes this build error:
> >> 
> >> drivers/net/xen-netback/interface.c: In function 'xenvif_free':
> >> drivers/net/xen-netback/interface.c:754:2: error: implicit declaration of 
> >> function 'vfree' [-Werror=implicit-function-declaration]
> >>   vfree(vif->queues);
> >>   ^
> >> cc1: some warnings being treated as errors
> >> 
> >> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> >> Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
> >> Cc: Andrew J. Bennieston <andrew.bennieston@xxxxxxxxxx>
> > 
> > Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> > 
> > This didn't happen to me when I built it on x86 though. Just curious,
> > did you build it on othet platform, say, ARM?
> 
> ARM and PowerPC will both show this problem.
> 
> The issue is that x86 get's linux/vmalloc.h implicitly through one of
> it's asm/ headers, thus you'll never hit the issue if you only build
> test on that arch.

Good to know. I shall keep an eye on this in the future.

Thanks
Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel