Re: [Xen-devel] [PATCH ARM v3 2/7] mini-os: fixed shutdown thread

[Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>]

Ian Campbell, le Thu 12 Jun 2014 10:52:29 +0100, a Ãcrit :
> On Wed, 2014-06-11 at 11:30 +0100, Thomas Leonard wrote:
> > diff --git a/extras/mini-os/kernel.c b/extras/mini-os/kernel.c
> > index ea409f4..27e3c56 100644
> > --- a/extras/mini-os/kernel.c
> > +++ b/extras/mini-os/kernel.c
> > @@ -69,6 +69,8 @@ void setup_xen_features(void)
> >  __attribute__((weak)) void app_shutdown(unsigned reason)
> >  {
> >      printk("Shutdown requested: %d\n", reason);
> > +    struct sched_shutdown sched_shutdown = { .reason = reason };
> > +    HYPERVISOR_sched_op(SCHEDOP_shutdown, &sched_shutdown);
> 
> I was going to apply but this causes:
>         kernel.c: In function âapp_shutdownâ:
>         kernel.c:72:5: error: ISO C90 forbids mixed declarations and code 
> [-Werror=declaration-after-statement]
>         cc1: all warnings being treated as errors

Ah, odd that they didn't get it. Just exchanging the printk and
sched_shutdown declaration will do it :)

Samuel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel