[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [Xen-Devel] [PATCH] [GSOC14] refactored mempaging code from xenpaging to libxc.

On 12/06/14 14:27, Ian Campbell wrote:
> On Thu, 2014-06-12 at 14:22 +0100, Andrew Cooper wrote:
>>> +# mem paging setup
>>> +GUEST_SRCS-y                 += xc_mem_paging_setup.c
>>> +
>> I don't think you need the comment here.  It is obvious from the name of
>> the file, although I would suggest you name it "xc_dom_paging.c" or
>> something a tad less specific.
> xc_dom_* are, for better or worse, generally domain builder related.
> Given the API is xen_mem_paging_* I don't think the name here is so bad,
> I might be inclined to drop the _setup if there is any chance of
> anything else being added here.

Hmm yes I suppose.  I would certainly drop the _setup, but
"xc_mem_paging.c" is fine.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.