Re: [Xen-devel] [Xen-Devel] [PATCH] [GSOC14] refactored mempaging code from xenpaging to libxc.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-06-12 at 15:11 +0100, Andrew Cooper wrote:


> >         
> >         > +    if ( mmap_pfn & XEN_DOMCTL_PFINFO_XTAB )
> >         
> >         
> >         What is this check for?
> > foreign_batch has the old semantics of setting the MSB of the pfn in
> > error. Maybe use map_foreign_bulk with cleaner error reporting? 
> > 
> 
> Eww.  That is a nasty interface, and will completely break 32bit
> toolstacks on machines with hotplug regions above the 8TB boundary.
> 
> Please do use map_foreign_bulk().

The stated purpose of this patch is code motion. Please don't encourage
people to also make functional changes in such patches.

If there is to be any cleanups/improvements then they should be done
later, but that won't affect the acceptance of this patch (assuming it
really is just motion, I've not checked in detail).

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel