[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v4 16/16] xen/arm: add SGI handling for GICv3

On 12/06/14 07:53, Vijay Kilari wrote:
    In GICv3 case the sending SGI by guest raises sysreg trap where
as in GICv2 it raises mmio write trap. So these traps lands in respective
vgic driver. ( mmio write trap => vgic-v2.c and sysreg => vgic-v3.c)
These vgic-v{2,3}.c driver calls generic vgic driver to inject SGI to VCPU.

What does prevent a malicious buggy gicv2 guest too call the sysreg version? AFAIU nothing, so you will end up to interpret GICv2 data as GICv3 data which will result to a possible security issue.

If I understand correctly, you mean creating callback in vgic, which is
common function in vgic driver and from there it should call
respective vgic-v{2,3}.c driver.

Yes, I see that on your new version you didn't use a callback. Please use it.


Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.