[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] IOMMU: Prevent VT-d device IOTLB operations on wrong IOMMU

>>> Andrew Cooper <andrew.cooper3@xxxxxxxxxx> 06/12/14 2:05 PM >>>
>>On 12/06/14 12:40, Malcolm Crossley wrote:
>> --- a/xen/drivers/passthrough/ats.h
>> +++ b/xen/drivers/passthrough/ats.h
>> @@ -24,6 +24,7 @@ struct pci_ats_dev {
>>      u8 bus;
>>      u8 devfn;
>>      u16 ats_queue_depth;    /* ATS device invalidation queue depth */
>> +    void *iommu;
>This could really do with a comment here explaining why a void *, and
>which two types of structure it could end up pointing at.

Right. Or make it a transparent union in the first place. And in any case, 
more clear that it's for nothing but looking at, add "const".


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.