[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 7/8] xen: arm: use superpages in p2m when pages are suitably aligned

>>> On 13.06.14 at 19:45, <julien.grall@xxxxxxxxxx> wrote:
> On 13/06/14 15:08, Ian Campbell wrote:
>> On Thu, 2014-06-12 at 10:00 +0100, Julien Grall wrote:
>>> On 12/06/14 08:30, Ian Campbell wrote:
>>>> On Wed, 2014-06-11 at 23:19 +0100, Julien Grall wrote:
>>>>> Hi Ian,
>>>>> While I was looking closer to this patch I found something strange. Why
>>>>> all the callers of guest_physmap_add_page in the directory common don't
>>>>> check that the function success to create the mapping?
>>>> "directory common"? I don't get your meaning.
>>> Sorry, I meant xen/common/
>> I don't know the answer then.
> CC Jan and Keir. I hope one of them have a clue on this.

The answer is likely the usual one: When this code got added, not
enough care was taken to deal with possible errors. Adding error
handling where it's missing is always a welcome thing.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.