Re: [Xen-devel] [PATCH OSSTEST] Implement direct IPMI power control. (Was: Re: [xen-unstable test] 27133: regressions - trouble: broken/fail/pass)

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("[PATCH OSSTEST] Implement direct IPMI power control. 
(Was: Re: [Xen-devel] [xen-unstable test] 27133: regressions - trouble: 
broken/fail/pass)"):
> diff --git a/Osstest/PDU/ipmi.pm b/Osstest/PDU/ipmi.pm
> new file mode 100644
> index 0000000..45d2946
> --- /dev/null
> +++ b/Osstest/PDU/ipmi.pm
> @@ -0,0 +1,67 @@
...
> +    my $status = `$cmd power status`
> +     or die "Cannot retrieve current power status";
> +    chop($status);

This all looks fine except that you should be using "chomp" here
rather than "chop".  (You nearly always want chomp.)

With that changed, you can put my ack on it.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel