[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH v5 7/7] arch/x86: Comment out efi_set_rtc_mmss()
- To: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>, Daniel Kiper <daniel.kiper@xxxxxxxxxx>
- From: Juergen Gross <jgross@xxxxxxxx>
- Date: Mon, 16 Jun 2014 13:54:17 +0200
- Cc: mjg59@xxxxxxxxxxxxx, jeremy@xxxxxxxx, linux-efi@xxxxxxxxxxxxxxx, ian.campbell@xxxxxxxxxx, andrew.cooper3@xxxxxxxxxx, x86@xxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, matt.fleming@xxxxxxxxx, david.vrabel@xxxxxxxxxx, jbeulich@xxxxxxxx, hpa@xxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, tglx@xxxxxxxxxxxxx, mingo@xxxxxxxxxx, boris.ostrovsky@xxxxxxxxxx, eshelton@xxxxxxxxx
- Delivery-date: Mon, 16 Jun 2014 11:54:30 +0000
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
On 06/16/2014 01:43 PM, Stefano Stabellini wrote:
On Fri, 13 Jun 2014, Daniel Kiper wrote:
efi_set_rtc_mmss() is never used to set RTC due to bugs found
on many EFI platforms. It is set directly by mach_set_rtc_mmss().
Signed-off-by: Daniel Kiper <daniel.kiper@xxxxxxxxxx>
---
arch/x86/platform/efi/efi.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c
index deb4f05..bd3e080 100644
--- a/arch/x86/platform/efi/efi.c
+++ b/arch/x86/platform/efi/efi.c
@@ -244,6 +244,11 @@ static efi_status_t __init
phys_efi_set_virtual_address_map(
return status;
}
+#if 0
+/*
+ * efi_set_rtc_mmss() is never used to set RTC due to bugs found
+ * on many EFI platforms. It is set directly by mach_set_rtc_mmss().
+ */
int efi_set_rtc_mmss(const struct timespec *now)
{
unsigned long nowtime = now->tv_sec;
@@ -279,6 +284,7 @@ int efi_set_rtc_mmss(const struct timespec *now)
}
return 0;
}
+#endif
"Commenting out" code like that is not a good idea: it leaves
dead-rotting functions in the middle of your source file.
If the function is not used, just go ahead and remove it. We can use git
to get it back.
And shouldn't it be removed from include/linux/efi.h as well?
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel
|
