Re: [Xen-devel] [PATCH] xen/grant-table: fix suspend for non-PV guests

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Mon, Jun 16, 2014 at 12:49:18PM +0100, David Vrabel wrote:
> Commit aa8532c32216ae07c3813b9aeb774517878a7573 (xen: refactor suspend
> pre/post hooks) broke resuming PVHVM (auto-translated physmap) guests.
> 
> The gnttab_suspend() would clear the mapping for the grant table
> frames, but the ->unmap_frames() call is only applicable to PV guests.
> 
> Signed-off-by: David Vrabel <david.vrabel@xxxxxxxxxx>

You forgot:

Reported-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>

However, if the code is structured like this, should we just
make the 'unmap_frames' be a NOP for HVM and instead have:


if (gnttab_interface->unmap_frames)
        gnttab_interface->unmap_frames();

And the HVM path will make sure that 'unmap_frames' is
set to NULL?

Maybe even change the name to 'unmap_frames_pv' ?

> ---
>  drivers/xen/grant-table.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c
> index 6d325bd..5d4de88 100644
> --- a/drivers/xen/grant-table.c
> +++ b/drivers/xen/grant-table.c
> @@ -1168,7 +1168,8 @@ int gnttab_resume(void)
>  
>  int gnttab_suspend(void)
>  {
> -     gnttab_interface->unmap_frames();
> +     if (!xen_feature(XENFEAT_auto_translated_physmap))
> +             gnttab_interface->unmap_frames();
>       return 0;
>  }
>  
> -- 
> 1.7.10.4
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel