[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v7 1/9] xl / libxl: push parsing of SSID and CPU pool ID down to libxl

On 06/17/2014 05:32 AM, Wei Liu wrote:
This patch pushes parsing of "init_seclabel", "seclabel",
"device_model_stubdomain_seclabel" and "pool" down to libxl level.

Originally the parsing is done in xl level, which is not ideal because
libxl won't have the truely relevant information. With this patch libxl
holds important information by itself.

The libxl IDL is extended to hold the string of labels and pool name.
And if there those strings are present they take precedence over the
numeric representations.

As all relevant structures (libxl_dominfo etc) have a field called
X_name / X_label now, a string is also copied there so that callers
won't have to do ID to name / label translation.

In order to be compatible with users of older versions of libxl, this
they are defined, the respective strings are available. And if those
strings are not NULL, libxl will do the parsing and ignore the numeric

Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
Cc: Dario Faggioli <dario.faggioli@xxxxxxxxxx>
Cc: Juergen Gross <jgross@xxxxxxxx>
Cc: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>

This change looks good to me (untested), although I don't believe I am
listed as a maintainer for any of it.

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
  tools/libxl/libxl.c         |   22 +++++++--
  tools/libxl/libxl.h         |   20 ++++++++
  tools/libxl/libxl_create.c  |   57 +++++++++++++++++++++++
  tools/libxl/libxl_dm.c      |    4 ++
  tools/libxl/libxl_types.idl |    6 +++
  tools/libxl/xl_cmdimpl.c    |  107 ++++++++++++-------------------------------
  tools/libxl/xl_sxp.c        |    7 +--
  7 files changed, 137 insertions(+), 86 deletions(-)

Daniel De Graaf
National Security Agency

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.