Re: [Xen-devel] [PATCH v5 00/21] xen/arm: Add GICv3 support

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2014-06-18 at 09:13 +0530, Vijay Kilari wrote:
> On Tue, Jun 17, 2014 at 9:09 PM, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> >
> > On Thu, 2014-06-12 at 19:06 +0530, vijay.kilari@xxxxxxxxx wrote:
> >> From: Vijaya Kumar K <Vijaya.Kumar@xxxxxxxxxxxxxxxxxx>
> >>
> >> Made changes to existing gic and vgic drivers
> >> to make it generic and added support for GIC v3
> >> hw version
> >
> > I've just been through patches 1..15 and with the exception of #12 it
> > seems to me that they are all either acked or have mostly minor
> > comments. From 16 onwards it seems like we are getting more into the
> > meat of v3 support and there are still some substantive comments
> > (although I've not looked closely to see how substantive).
> >
> > With that in mind perhaps you'd like to address the comments on 1..15
> > and repost "v6a" with just those precursor/cleanup/refactoring patches? That
> > way we can get them in and reduce the size of your outstanding work
> > pretty substantially, which I hope would make stuff easier for you going
> > forward, since I bet all that code motion is a real pain to rebase...
> >
> 
>   My patch series is based on Stefano's 'no_maintenance_interrupts' v8.
> So before you take my patches, Stefano's patches should be merged

Ah, OK, I'd forgotten this dependency.

I've just committed Stefano's patches (v9) so hopefully that will help a bit.


> > OTOH I'm out of the office Thursday-Monday inclusive so unless you think
> > you will have this stuff ready before tomorrow early afternoon (BST, to
> > give me time to commit) then there is no rush. Or if on Tuesday you've
> > got the stuff up to #15 ready to repost you might as well go ahead with
> > it.
> 
>   I think it may not be possible for me to do it by tomorrow. I have to
> rebase and commit my changes on top of Stefano's v9 version.

Sure, no problem.

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel